Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause the emulator based on mouse focus #2224

Merged
merged 4 commits into from Mar 19, 2015
Merged

Conversation

gerikkub
Copy link
Contributor

This was requested in issue #8232. Adds the option to pause the emulator when the mouse leaves the render window's focus. Defaults to false.

@skidau
Copy link
Contributor

skidau commented Mar 17, 2015

Could add a checkbox for this under Config > Interface

@MayImilae
Copy link
Contributor

Added the ability to pause the emulator by moving the mouse outside the window

So just moving the mouse away from the window makes the emulator pause? It doesn't even require clicking away? That doesn't sound like it would work very well for emulated wiimote users...

Why not have it pause when clicked away like most programs?

@gerikkub
Copy link
Contributor Author

"Why not have it pause when clicked away like most programs?"

That seems like a better idea. I'll change it to pause when focus is moved away from the rendering window.

@@ -486,6 +488,7 @@ void CConfigMain::InitializeGUITooltips()
ConfirmStop->SetToolTip(_("Show a confirmation box before stopping a game."));
UsePanicHandlers->SetToolTip(_("Show a message box when a potentially serious error has occurred.\nDisabling this may avoid annoying and non-fatal messages, but it may result in major crashes having no explanation at all."));
OnScreenDisplayMessages->SetToolTip(_("Display messages over the emulation screen area.\nThese messages include memory card writes, video backend and CPU information, and JIT cache clearing."));
PauseOnFocusLost->SetToolTip(_("Pauses the emulator when focus is taken away from the emulation screen."));

This comment was marked as off-topic.

@skidau
Copy link
Contributor

skidau commented Mar 17, 2015

@dolphin-emu-bot rebuild

skidau added a commit that referenced this pull request Mar 19, 2015
Pause the emulator based on mouse focus
@skidau skidau merged commit 7d800b6 into dolphin-emu:master Mar 19, 2015
@@ -577,6 +580,7 @@ void CConfigMain::CreateGUIControls()
ConfirmStop = new wxCheckBox(DisplayPage, ID_INTERFACE_CONFIRMSTOP, _("Confirm on Stop"));
UsePanicHandlers = new wxCheckBox(DisplayPage, ID_INTERFACE_USEPANICHANDLERS, _("Use Panic Handlers"));
OnScreenDisplayMessages = new wxCheckBox(DisplayPage, ID_INTERFACE_ONSCREENDISPLAYMESSAGES, _("On-Screen Display Messages"));
PauseOnFocusLost = new wxCheckBox(DisplayPage, ID_INTERFACE_PAUSEONFOCUSLOST, _("Pause on Focus Lost"));

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
7 participants