JitIL: Fix a bug in floatpoint load/store instructions. #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regBuildMemAddress function already clears the address register. Not only is clearing it again pointless, regBuildMemAddress uses the bits in IInfo slightly diffrently and the second clear can clear the wrong registers causing bugs if something else actually needs to use those registers.
|
Add some comments, could you check them @magumagu? |
| @@ -420,6 +433,7 @@ static void regNormalRegClear(RegInfo& RI, InstLoc I) | |||
| regClearInst(RI, getOp2(I)); | |||
| } | |||
|
|
|||
| // Clear any floating point registers which end their lifetime at I | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
The change looks correct... as far as it goes. Ideally, the code would be changed so there's only one place where we decide which instructions are actually "used" by an instruction, as in regMarkMemAddress etc. |
| @@ -412,6 +423,8 @@ static X64Reg regBinLHSReg(RegInfo& RI, InstLoc I) | |||
| return reg; | |||
| } | |||
|
|
|||
| // Clear any registers which end their lifetime at I | |||
| // Don't use this for special instructions like memory load/stores | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Bump? |
|
We need someone to review this? @FioraAeterna @magumagu ? It's important for JITIL to at least be functional. |
Sonicadvance1
added a commit
that referenced
this pull request
May 26, 2015
JitIL: Fix a bug in floatpoint load/store instructions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regBuildMemAddress function already clears the address register.
Not only is clearing it again pointless, regBuildMemAddress uses the bits in IInfo slightly differently and the second clear can clear the wrong register, causing bugs if something else actually needs to use those registers.
Fixes issue 8437 and #2166