Project

General

Profile

Actions

Emulator Issues #2999

closed

Tales of Graces Sky texture error right after r5896 revision changes

Added by b166359l over 13 years ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
GFX
% Done:

0%

Operating system:
N/A
Issue type:
Bug
Milestone:
Regression:
No
Relates to usability:
No
Relates to performance:
No
Easy:
No
Relates to maintainability:
No
Regression start:
Fixed in:

Description

What steps will reproduce the problem?
1.Run Tales of Graces after r5896 revision changes.
2.Some texture error in the sky.

What is the expected output? What do you see instead?
Fix the Sky texture like before.
Dolphin version with the problem? Other Dolphin version without the
problem?

32-bit or 64-bit and any other build parameters?
both 32bit and 64bit.
OS version and versions of tools/libraries used?
windows 7
Please provide any additional information below.
This is the screenshot in r5895:
http://a.imageshack.us/img841/6048/stgjaf1.png
This is the screenshot after revision r5896:
http://a.imageshack.us/img841/4261/stgjaf2.png
Already try changing both Direct3D9 and Direct3D11 plugins.
Toggle on/off "EFB Scaled Copy" Hack.
And change "EFB Copy" into both "copy to texture" and "copy to ram".
But the problems still there.
I think it may be some shader changes in the videocommon causing this?

Actions #1

Updated by b166359l over 13 years ago

Self fixed...

Actions #2

Updated by BhaaL over 13 years ago

How about you also tell us how you fixed it?

Actions #3

Updated by b166359l over 13 years ago

Sorry, it seem still not fix.
I revert a line in the VertexShaderGen.cpp in the videocommon.

WRITE(p, "o.pos.z = "I_DEPTHPARAMS".x * o.pos.w + o.pos.z * "I_DEPTHPARAMS".y;\n");

I thought I fix it, but it seem not...
It helps a little, but it still get some texture error...
So, please reopen this issue.
Sorry for my mistake...

Actions #4

Updated by BhaaL over 13 years ago

  • Status changed from New to New

r5896 i presume?

Actions #5

Updated by skidau over 13 years ago

  • Category set to gfx
Actions #6

Updated by NeoBrainX over 12 years ago

Is this still an issue?

Actions #7

Updated by carlos.ismael.braz over 12 years ago

This issue is still happening, I'm testing with Dolphin 3.0-96 (Git) x64

Actions #8

Updated by NeoBrainX over 12 years ago

Upload new screenshots please, the other links don't work anymore.

Actions #9

Updated by DimitriPilot3 over 12 years ago

Also, being able to know the hash of a GIT revision coming from a SVN revision (in this case: r5896, which is said to be the culprit) is a nice time saver.

SVN r5896 == GIT rf78133f261f45dced11142cb546feba7a389d416
(Found by searching the SVN commit log with TortoiseSVN, and then copying a part of the commit description which I pasted into TortoiseGit. I dunno if there's an easier way, as I didn't fetch SVN-related data from the repository using TortoiseGIT yet... (And how would I do it with an existing GIT clone? What commands should I type?))

If you didn't already notice it, a "git-svn-id" line was appended to the description of all commits coming from SVN, including the original SVN revision number which is found at the end of the URL (which no longer works at this point).

Actions #10

Updated by carlos.ismael.braz over 12 years ago

The GIT revision was http://code.google.com/p/dolphin-emu/source/detail?r=5ea2b1b519f02bd485a5c24a1db1145c48982be5, I will try to get some screenshots for you to see

Actions #11

Updated by NeoBrainX over 12 years ago

DimitriPilot3: you can use TGit to search the log messages for the svn revision numbers, we deliberately added those to all old commit messages so that one can easily find them. You seem to know about that already, so I wonder why you're doing it the hard way :P
fwiw, apart from the rev numbers in the log messages there is no other "SVN-related data" in the repository anymore.

Actions #12

Updated by DimitriPilot3 over 12 years ago

You can use TGit to search the log messages for the svn revision numbers, we deliberately added those
to all old commit messages so that one can easily find them. You seem to know about that already,
so I wonder why you're doing it the hard way :P

Hmm, last time I tried, I seemed to remember not getting useful results (with the search you mentioned) for some reason, maybe because I used "quotation marks" and TortoiseGit included them into the search...
Just tried it again without quotation marks, and it definitely works - flexibly enough to allow searching for exactly "@55 " instead of "@55" (again, don't use quotation marks!), which narrows all those results to just one result.
So I guess I don't need to worry about configuring/initializing git-svn (if needed), then :P

Actions #14

Updated by Billiard26 over 11 years ago

  • Issue type set to Bug
Actions #15

Updated by Autoran1 about 11 years ago

  • Status changed from New to Fixed

Game looks great on Recent builds, with all backends, whatever it was it's fixed now

Actions

Also available in: Atom PDF