NetKDTime: Use UTC based timestamp instead of localtime. #11435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techydude0713
force-pushed
the
wc24-utc-fix
branch
from
b1bcdd2
to
15db9a7
Compare
techydude0713
force-pushed
the
wc24-utc-fix
branch
from
15db9a7
to
e2db9cd
Compare
|
Buildbot failed when trying to download the repo, could this PR be rebuilt? |
|
@dolphin-emu-bot rebuild |
phire
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR #11431
Related to issue 9754.
Since GetEmulatedTime returns a timestamp based off the computer's timezone, it needs to be changed to UTC here.
This allows for the News Channel to produce the correct "Last Updated" time.
This code is based off from a function in Core/Movie.cpp, which uses the same method.
By using a NAND dump with the latest news data, the "last updated" time is accurate to the console's results.