Don't read/store settings directly from/to SYSCONF (and fix config restore) #4319
Conversation
leoetlino
force-pushed
the
sysconf
branch
2 times, most recently
from
539fad8
to
59d31c2
Compare
Aren't indirect includes great?
|
Review status: 0 of 32 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Source/Core/Core/BootManager.h, line 14 at r1 (raw file):
You should probably document what this actually does. Source/Core/Core/Core.cpp, line 85 at r1 (raw file):
You can just include the header. Comments from Reviewable |
|
Review status: 0 of 32 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed. Source/Core/Core/BootManager.h, line 14 at r1 (raw file):
|
leoetlino
changed the title
Instead of directly reading/storing settings from/to the SYSCONF, we now store Wii settings to Dolphin's own configuration, and apply them on boot. This prevents issues with settings not being saved, being overridden and lost (if the user opens a dialog that writes to the SYSCONF while a game is running). This also fixes restoring settings from the config cache after a graceful shutdown; for some reason, settings were only restored after a normal shutdown. Fixes issue 9825 and 9826
leoetlino
changed the title
|
Can we please get some urgent review on this. This is a critical bug that could corrupt people's configurations and lead to things like SyncGPU getting permanently enabled. |
|
What about using the sysconf from nand dump scenario? |
|
I pushed an update earlier today so that it reads settings from the SYSCONF on startup, so both the NAND dump and existing SYSCONF cases should be handled correctly. |
|
why has msghandler.h been included in a lot of otherwise-unchanged files? |
|
Indirect includes. They depended on ConfigManager to include SysConf.h to include MsgHandler.h, and removing the SysConf.h include in ConfigManager.h broke everything. |
Instead of directly reading/storing settings from/to the SYSCONF, we now store Wii settings to Dolphin's own configuration, and apply them on boot. This prevents issues with settings not being saved, being overridden and lost (if the user opens a dialog that writes to the SYSCONF while a game is running).
This also fixes restoring settings from the config cache after a graceful shutdown; for some reason, settings were only restored after a normal shutdown.
Fixes issue 9825 and 9826
This change is