ConfigManager: Sync Dolphin settings to SYSCONF on exit #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4319 made Dolphin not read/write directly to the SYSCONF and read settings from the SYSCONF at boot, and only write Dolphin settings to the SYSCONF at emulation startup. However, this also made it a bit confusing, because if settings were changed, then Dolphin was exited without starting a game in between, the settings wouldn't actually get persisted. This is fixed by syncing Dolphin settings with the SYSCONF when Dolphin exits.
|
For SYSCONF you mean the config.ini in user/documents/Dolphin or is there another configuration file? |
|
This is about the SYSCONF file in the NAND. |
|
And where do I find it? I'm asking because I think something got corrupted in my Wiimote config files and wanted to set it back to deafult... |
|
shared2/sys/SYSCONF (in the NAND) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4319 made Dolphin not read/write directly to the SYSCONF and read settings from the SYSCONF at boot, and only write Dolphin settings to the SYSCONF at emulation startup.
However, this also made it a bit confusing, because if settings were changed, then Dolphin was exited without starting a game in between, the settings wouldn't actually get persisted. This is fixed by syncing Dolphin settings with the SYSCONF when Dolphin exits.
This change is