Common: Add a Subscribable class (from #5758) #6264

leoetlino · 2017-12-20T20:49:03Z

From PR #5758 (rebased on top of master)

Adds a Subscribable class in Common, to encapsulate the callback management logic. Could probably be used in other places with callbacks, too. Calling Subscribable().Subscribe returns a move-only value that, when destructed, unsubscribes the callback if the original Subscribable still exists (thread-safe).

This is not used anywhere yet, but I plan to replace the existing callbacks with Subscribables (Core::SetOnStoppedCallback, config change callbacks).

Source/Core/Common/NoDiscard.h

@@ -0,0 +1,20 @@
+// Copyright 2017 Dolphin Emulator Project


Source/Core/Common/Subscribable.h

+    Subscribable* subscribable = nullptr;
+  };
+
+  void Unsubscribe(SubscriptionID id) { m_callbacks.erase(id); }


degasus · 2018-01-05T15:06:03Z

The common helper LGTM.

leoetlino · 2019-05-10T19:37:06Z

I'll re-submit this if/when I actually end up using this utility.

leoetlino mentioned this pull request Dec 20, 2017

[WIP] Config: Port Main.Core and Main.DSP to OnionConfig #5881

Closed

lioncash reviewed Dec 20, 2017

View reviewed changes

leoetlino mentioned this pull request Dec 25, 2017

Enable C++17 #6273

Merged

degasus reviewed Jan 5, 2018

View reviewed changes

Source/Core/Common/Subscribable.h Outdated

Subscribable* subscribable = nullptr;

};

void Unsubscribe(SubscriptionID id) { m_callbacks.erase(id); }

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

leoetlino force-pushed the subscribable branch from ddada46 to 1eeec5c Compare January 5, 2018 20:59

ligfx added 2 commits April 12, 2018 22:22

Common: add NoDiscard.h

5bf94f8

Common: add Subscribable

25748b8

leoetlino force-pushed the subscribable branch from 1eeec5c to 25748b8 Compare April 12, 2018 20:23

leoetlino closed this May 10, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Common: Add a Subscribable class (from #5758) #6264

Common: Add a Subscribable class (from #5758) #6264

leoetlino commented Dec 20, 2017 •

edited

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

degasus commented Jan 5, 2018

leoetlino commented May 10, 2019

Common: Add a Subscribable class (from #5758) #6264

Common: Add a Subscribable class (from #5758) #6264

Conversation

leoetlino commented Dec 20, 2017 • edited

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

This comment was marked as off-topic.

degasus commented Jan 5, 2018

leoetlino commented May 10, 2019

leoetlino commented Dec 20, 2017 •

edited