Boot: Migrate to new filesystem interface #6807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change SettingsHandler to take a buffer instead of assuming that the setting file to read is always on the host filesystem for more flexibility and make it possible to use the new filesystem interface.
Since we're going to need it in the boot code, move it out to a separate, easily reusable function. This also makes the InitImport logic clearer.
BhaaLseN
approved these changes
May 10, 2018
| /// | ||
| /// Normally, this is automatically done by ES when the System Menu is installed, | ||
| /// but we cannot rely on this because we don't require any system titles to be installed. | ||
| void CreateSystemMenuTitleDirs(); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for the migration work started in 8317a66
The goal is to make all accesses to the Wii filesystem go through the common interface so that we can switch to a different storage and keep track of things like metadata in the future.
The first commit changes SettingsHandler to take a buffer instead of assuming that the setting file to read is always on the host filesystem for more flexibility and make it possible to use the new FS code.
The third commit moves title directory creation code into a separate function that can easily be called from the boot code. We can't assume that the System Menu title dirs exist as we don't require users to install system titles, so we need to create them in the boot code with the proper permissions ourselves.
The last commit changes the remaining parts of the boot code to use the new FS interface, creating title dirs for 1-2 if necessary.