WiiRoot: Copy initial NAND files with proper metadata #6832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{Initialize,Shutdown}WiiRoot should only be responsible for setting the
SESSION_WII_ROOT or managing the temporary NAND directory.
Move all the content manipulation out of these functions to ensure
separation of concerns and call them after/before WiiRoot init/shutdown
to make sure they operate on the correct root.
Dolphin doesn't use any of the WC24 files, so this can be done when actually starting emulation in WiiRoot. The benefit of moving the copy is that we don't need to handle temporary NANDs in a special way.
These are created by the ECDK library (used in the Wii Shop Channel for example) on first use. There's no need to provide dummy files.
BhaaLseN
approved these changes
May 12, 2018
lioncash
approved these changes
May 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the initial NAND file copy code, moves it to WiiRoot (to unify it with the temporary NAND init code) and makes sure the files and directories are created with the proper metadata (last commit).
And while I was at it, I added a comment explaining why exactly it is required to copy the dummy NWC24 files to the NAND.