Looks nice, how does debugger look?
@dolphin-emu-bot rebuild

I've fixed the errors that made the Linux build fail (hopefully).

As for the debugger, I'm taking a good look at it now. As of this moment, the two drop-down buttons are on their own ugly-toolbar, which I'm looking to fix.

Is it intentional that there is a short fade-in and fade-out when hovering over the toolbar buttons? The rest of the buttons don't have this behaviour. Personally I prefer the old behaviour.

Also, when pressing the Play/Pause button the toolbar changes width whereas previously the width would stay the same. The toolbar width should be fixed in my opinion.

Finally, I'm using windows. Looks pretty good apart from the mentioned remarks.

I think the fading looks good, just personal opinion though...but would
probably look better if there were no tooltips popping up for the menubar
items (or maybe just took longer to trigger). The fading is also consistent
with animation of other highlights which you probably don't even notice,
like hovering over clickable buttons, tabs, etc. in other dolphin dialogs.

On Fri, Aug 8, 2014 at 3:26 PM, Oussama Danba notifications@github.com
wrote:

Is it intentional that there is a short fade-in and fade-out when hovering
over the toolbar buttons? The rest of the buttons don't have this
behaviour. Personally I prefer the old behaviour.

Also, when pressing the Play/Pause button the toolbar changes width
whereas previously the width would stay the same. The toolbar width should
be fixed in my opinion.

Finally, I'm using windows. Looks pretty good apart from the mentioned
remarks.

—
Reply to this email directly or view it on GitHub
#761 (comment).

So I've integrated the drop-down buttons, now I need to find a way to re-enable their dropdown function :/

@dolphin-emu-bot rebuild
To see what changes look like..

I'm considering moving the perspective buttons to the menu. What do you think?

SGTM. To be honest I don't know if the perspective feature even works. For sure it's not intuitive/easy to use.

Also, there are wxwidgets asserts firing when launching debugger.

@shuffle2 The last time I accidentally clicked on edit for perspectives it seemed to work. Does anyone even really use perspectives?

Yeah, I'm reverting that entire last commit I made, which broke the perspectives. From there, I think I'll move all that stuff into the menubar.

@lioncash well, in theory they are very nice...maybe it does work now, idk. I just know that when I was using dolphin's debugger heavily, they didn't work properly, so I'd have to rearrange the AUI windows every time a debugger session started :/

@shuffle2 Ah ok.

It should be working fine on OS X and Linux, for the most part. I ran into an issue on Linux where the play button refuses to change its text to "pause", which doesn't happen on OS X or Windows. It should be able to compile with the buildbot at this point, and now I'm going to test on Windows.

I've removed the commit that was reverted (and the revert commit as well) using git rebase -i. As it turns out, the pause button issue does not happen on Windows, only Linux indeed.

@dolphin-emu-bot rebuild

This fixes issue 6351.

lgtm

looks good to me