[WIP] Fix network hanging issues #8756
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sepalani
changed the title
|
I added a timeout on blocking connect call based on this hardware test. Beware that it tries to connect to an ubisoft server (which timeout after ~3 minutes on hardware). I'll need to reverse IOS to confirm that behaviour, however. |
|
Since all these commits will require appropriate hwtest, I'll split them in different PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should truly fix: https://dolp.in/i11867
What happened (assuming there is no timing issues):
RecvFromcallSOCleanupwhich:IOCTL_NWC24_CLEANUP_SOCKETIOS_Closeon the network handlesoState = 1(soState = 2before this)SOClosebutioctlvisn't fired becausesoState = 1In other words,
RecvFromwon't get a response and will wait forever (since Dolphin doesn't receiveIOCTL_SO_CLOSE), again...It might require a hardware test to confirm that's the intended behaviour.
Ready to be reviewed.